Skip to content

feat(k8s): fix version list and add a golden test#1769

Merged
remyleone merged 1 commit intoscaleway:masterfrom
remyleone:fix_list_version
Feb 18, 2021
Merged

feat(k8s): fix version list and add a golden test#1769
remyleone merged 1 commit intoscaleway:masterfrom
remyleone:fix_list_version

Conversation

@remyleone
Copy link
Copy Markdown
Member

@remyleone remyleone commented Feb 18, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Sh4d1
Sh4d1 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit d936977 into scaleway:master Feb 18, 2021
@remyleone remyleone deleted the fix_list_version branch February 18, 2021 14:35
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Sh4d1 Sh4d1 Sh4d1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

k8s Kubernetes Kapsule issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remyleone @Sh4d1