Skip to content

feat(as): add server type list format#1748

Merged
remyleone merged 2 commits intoscaleway:masterfrom
remyleone:server_type_list
Feb 8, 2021
Merged

feat(as): add server type list format#1748
remyleone merged 2 commits intoscaleway:masterfrom
remyleone:server_type_list

Conversation

@remyleone
Copy link
Copy Markdown
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Copy link
Copy Markdown
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this type of use case, you should rely on human marshaling override. Overriding the response type in an interceptor makes you loose data in the JSON output

@remyleone remyleone merged commit 168d2e6 into scaleway:master Feb 8, 2021
@remyleone remyleone deleted the server_type_list branch February 8, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants