Skip to content

Remove cycle_stash from type_of_opaque and related Value impls#153247

Draft
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Zoxc:type_of_opaque-cycle
Draft

Remove cycle_stash from type_of_opaque and related Value impls#153247
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Zoxc:type_of_opaque-cycle

Conversation

@Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 1, 2026

This removes cycle_stash from type_of_opaque and related Value impls. The motivation here is to allow removal of query cycle recovery.

This reverts #117241.

The auto-trait-leak.rs test has the most interesting change. I feel like switching to the normal cycle error is ok here. It shows the cycle unlike the old error, but it more verbose and lacks the span for Send (maybe it could be added to the trait selection obligation query?). It could probably be made less verbose with a custom handler using #153028 too.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 1, 2026
@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15      105M  6.2M   99M   6% /boot/efi
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (94917552KB >= 52428800KB). Skipping cleanup.
##[group]Run echo "[CI_PR_NUMBER=$num]"
echo "[CI_PR_NUMBER=$num]"
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants