Remove cycle_stash from type_of_opaque and related Value impls#153247
Draft
Zoxc wants to merge 1 commit intorust-lang:mainfrom
Draft
Remove cycle_stash from type_of_opaque and related Value impls#153247Zoxc wants to merge 1 commit intorust-lang:mainfrom
cycle_stash from type_of_opaque and related Value impls#153247Zoxc wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
cycle_stashfromtype_of_opaqueand relatedValueimpls. The motivation here is to allow removal of query cycle recovery.This reverts #117241.
The
auto-trait-leak.rstest has the most interesting change. I feel like switching to the normal cycle error is ok here. It shows the cycle unlike the old error, but it more verbose and lacks the span forSend(maybe it could be added to thetrait selection obligationquery?). It could probably be made less verbose with a custom handler using #153028 too.