Skip to content

refactor: add move check_align to parse_alignment#153189

Open
JayanAXHF wants to merge 3 commits intorust-lang:mainfrom
JayanAXHF:refactor/check_attrs_reftor_1
Open

refactor: add move check_align to parse_alignment#153189
JayanAXHF wants to merge 3 commits intorust-lang:mainfrom
JayanAXHF:refactor/check_attrs_reftor_1

Conversation

@JayanAXHF
Copy link
Member

@JayanAXHF JayanAXHF commented Feb 27, 2026

Part of #153101

r? @JonathanBrouwer

PS: jonathan i'm not sure about what to do with check_align now

@rustbot
Copy link
Collaborator

rustbot commented Feb 27, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2026
@JayanAXHF JayanAXHF added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-AST Area: AST labels Feb 27, 2026
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2026
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rust-log-analyzer

This comment has been minimized.

@JayanAXHF
Copy link
Member Author

@JonathanBrouwer I think i've finally gotten everything in order :D

@JayanAXHF JayanAXHF force-pushed the refactor/check_attrs_reftor_1 branch from a1cb53e to a026d9d Compare March 1, 2026 14:53
@JonathanBrouwer
Copy link
Contributor

I'll take a look sometime in the next few days :)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-AST Area: AST A-attributes Area: Attributes (`#[…]`, `#![…]`) C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants