feat: refactor GpuType enum names, add B200 and RTX PRO 6000s#233
feat: refactor GpuType enum names, add B200 and RTX PRO 6000s#233
Conversation
QA ReportStatus: MERGE WITH NOTES Breaking Change AnalysisRenamed enums (NVIDIA_ prefix removed from all 16 members):
Backward compatibility: No aliases or deprecation warnings provided. Old enum names will raise Downstream impact:
CI ResultsAll checks passing:
New GPU Validation
Issues Found[P1] RTX PRO 6000 variants missing from Suggested fix: either add them to an existing pool (e.g., [P2] No backward-compatible aliases for renamed enums # Backward-compatible aliases (deprecated)
NVIDIA_GEFORCE_RTX_4090 = GEFORCE_RTX_4090
NVIDIA_L4 = L4
# etc.[P3] No test coverage for new GPU types PR Diff Analysis
RecommendationMERGE WITH NOTES -- The core rename is clean and CI passes. However, before or shortly after merge:
Generated by flash-qa agent |
167052a to
18e88e0
Compare
Adds
GpuType.RTX_PRO_6000_BLACKWELL_SERVER_EDITION,GpuType.RTX_PRO_6000_BLACKWELL_WORKSTATION_EDITION,GpuType.RTX_PRO_6000_BLACKWELL_MAX_Q_WORKSTATION_EDITION, andGpuType.B200.Adds
GpuGroup.BLACKWELL_180andGpuGroup.BLACKWELL_96enum membersAlso refactors the
GpuTypeenum to remove theNVIDIA_prefix from all enum identifiers.