This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Using textmate scopes to find pairs#670
Closed
graceful-potato wants to merge 2 commits intorubyide:masterfrom
Closed
Using textmate scopes to find pairs#670graceful-potato wants to merge 2 commits intorubyide:masterfrom
graceful-potato wants to merge 2 commits intorubyide:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
======================================
Coverage 5.08% 5.08%
======================================
Files 10 10
Lines 118 118
Branches 20 20
======================================
Hits 6 6
Misses 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Contributor
|
This is amazing! This'd make me so happy, thank you 🙏 |
Collaborator
|
Hi, Sorry, can't merge this. The file is already being processed through tree sitter. I'm not interested in shipping oniguruma and parsing the file again to support this. |
Contributor
Author
|
No problem, parsing file twice on every keystroke is not the best solution. I believe treesitter would be better here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains #666 and it is just a proof of concept.
Fix #656