This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Merged
Conversation
Collaborator
|
I'll look at this tomorrow probably. I'll need to have a new version cut in |
Collaborator
|
I took a look at this over the weekend. I'll merge this and cut a release so as to at least prevent the crash, but there's going to be some additional work required to fully support remote environments. |
Member
Author
@wingrunr21 let me know if you need any information from me for the remote support. |
Contributor
|
FYI a new release of tree-sitter-ruby was cut |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix microsoft/vscode-remote-release#153.
VS Code released Remote Development recently, which allows users to connect VS Code to an isolated remote environment, e.g., ssh box, container or WSL. As remote environment is using Nodejs instead of Electron patched Nodejs, current prebuilt tree sitter binaries won't work properly.
To fix this issue
tree-sitter-nodealready has prebuilt for Node so we want to do the same thing fortree-sitter-ruby, here is the PR for it Prebuilt for Electron and Node tree-sitter/tree-sitter-ruby#106