This repository was archived by the owner on Jul 31, 2023. It is now read-only.
add --force-exclusion flag to reek options#287
Merged
wingrunr21 merged 3 commits intorubyide:masterfrom May 18, 2019
pelted:reek-force-exclusion
Merged
add --force-exclusion flag to reek options#287wingrunr21 merged 3 commits intorubyide:masterfrom pelted:reek-force-exclusion
wingrunr21 merged 3 commits intorubyide:masterfrom
pelted:reek-force-exclusion
Conversation
Force excluding files specified in the configuration `exclude_paths` even if they are explicitly passed as arguments.
Merged
|
@rubyide Can you consider reviewing/merging/rejecting this PR? I thought about submitting one, but PR older than year still waiting for reaction are a bit discouraging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force excluding files specified in the configuration
exclude_pathseven if they are explicitly passed as arguments.Resolves problem with exclude_paths in the
.reekconfig being ignored since we run reek on single files rather than the whole project.Example that now works after this PR.
Make sure these boxes are checked before submitting your PR -- thanks in advance!