Fix keyword-as-hash handling for methods without keyword params#372
Merged
mame merged 1 commit intoruby:masterfrom Feb 18, 2026
Merged
Fix keyword-as-hash handling for methods without keyword params#372mame merged 1 commit intoruby:masterfrom
mame merged 1 commit intoruby:masterfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes TypeProf’s handling of calls like
foo(x: 1)when the callee does not declare keyword parameters.(scenario/known-issues/keywords.rb.)In those cases, keyword arguments are now treated as a trailing positional hash (Ruby-compatible), improving inference from
untypedto record/hash types.Details
Prism::NoKeywordsParameterNode(**nil) asno_keywordsin method AST metadata.ActualArguments#with_keywords_as_last_positional_hashto centralize argument normalization.MethodDefBox#pass_argumentsonly when:**nil.scenario/known-issues/keywords.rbtoscenario/args/keyword-as-hash.rb.