Fix fcall include handling with context-aware meta parsing#370
Merged
mame merged 1 commit intoruby:masterfrom Feb 18, 2026
Merged
Fix fcall include handling with context-aware meta parsing#370mame merged 1 commit intoruby:masterfrom
mame merged 1 commit intoruby:masterfrom
Conversation
Limit include/attr_* meta parsing to class/module top-level statements and add a regression scenario for fcall include. Co-authored-by: Cursor <cursoragent@cursor.com>
c28c8b1 to
d74adf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
scenario/known-issues/fcall-include.rb.The known issue was this kind of code:
TypeProf incorrectly treated
include(1)as metaincludein this context, so type inference became too loose.Details
This PR fixes it by changing AST parsing:
include/attr_reader/attr_accessorare treated as meta only at class/module top level.After this change:
scenario/regressions/fcall-include.rb.