Merged
Conversation
kou
reviewed
Jun 7, 2023
ext/stringio/stringio.c
Outdated
| long offset = NUM2LONG(rb_offset); | ||
|
|
||
| if (len < 0) { | ||
| rb_raise(rb_eArgError, "negative string size (or size too big)"); |
Member
There was a problem hiding this comment.
Could you add rb_len to error message?
ext/stringio/stringio.c
Outdated
| } | ||
|
|
||
| if (offset < 0) { | ||
| rb_exc_raise(rb_syserr_new(EINVAL, "pread: Invalid offset argument")); |
Member
There was a problem hiding this comment.
Could you add rb_offset to error message?
Contributor
Author
|
@kou I applied your suggestions. |
Both for being closer to real IOs and also because it's a convenient API in multithreaded scenarios.
Contributor
Author
|
@kou done.
No problem. Note that there are pre-existing failures on the JRuby suite, but the added test does pass on JRuby. |
headius
approved these changes
Jun 7, 2023
Contributor
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
JRuby part looks fine. I can do a small optimization (split out separate arities) once this is merged.
Member
|
OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both for being closer to real IOs and also because it's a convenient API in multithreaded scenarios.
cc @kddnewton @nobu