Revert "Remove Gem::DependencyInstaller#find_gems_with_sources"#3412
Revert "Remove Gem::DependencyInstaller#find_gems_with_sources"#3412deivid-rodriguez merged 1 commit intomasterfrom
Conversation
|
Hey @deivid-rodriguez 😃 Just to understand this correctly, we are reverting this because we didn't give enough time to people to be aware of the deprecation warning? |
|
I believe the gem is popular enough to justify reverting. Note that even if they fix the extension and release a new version, any I think @hsbt had some tools to grep for usages of code inside gems, we could run that to see if there's more usages. |
|
As an alternative, we could keep it as a "noop" returning That would allow |
|
Maybe we just should not include the commit that removed the method in the next release? Also if we put a deprecation warning in Rubygems code and people decide to ignore it we can't really do much about it. |
That is what I'm doing here, reverting that commit.
I don't think that a gem maintainer being a little slow (define "slow" anyways) when updating their code to be warning free on newer rubygems should affect end users that have nothing to do with maintenance of a single specific gem. This will not be breaking a single gem's maintainer workflow, this will be breaking This warning has only been out there for like, 3 months, anyways. I don't think it's enough time to just let this break. And I believe it's actually easier for us to keep this method as a noop for now, than to deal with all the issues about |
|
This is the list used with https://gist.github.com/hsbt/1565e70bfc41b5e6c64db791cd8df14d I thought we should revert this because this list includes |
This reverts commit 04c79d3. Final removal is postponed until next year until we find a better way to manage deprecations.
deivid-rodriguez
force-pushed
the
restore_find_gems_with_sources
branch
from
4adba41 to
3e1cf91
Compare
|
Thanks for double checking this @hsbt! |
3 participants
Description:
I noticed that a pretty popular gem,
ruby-debug-ide, is usingGem::DependencyInstaller#find_gems_with_sources, so removing this method means that installation of anyGemfileincludingruby-debug-idewill break in the next rubygems version.We obviously don't want that, so I'm reverting the removal for the moment.
Final removal is postponed until next year until we find a better way to manage deprecations (#3013).
Note that the check
ruby-debug-ideis actually broken, but we still don't want to break installing it. Hopefully, they will fix this and stop using this method soon. See ruby-debug/ruby-debug-ide#142.Closes #3411.
Tasks:
I will abide by the code of conduct.