Merged
Conversation
hsbt
approved these changes
Jun 17, 2024
WASI does not support concept to provide termios, so it is not possible to build io/console extension on WASI at the moment. However, `io/console` is used by many gems, and removing the dependency from them *conditionally* is impossible. So, this commit adds a check to skip building `io/console` extension on WASI just to pass `gem install` for the platform.
kateinoigakukun
force-pushed
the
katei/skip-wasi
branch
from
d5c0de9 to
76c72e0
Compare
Member
Author
|
Confirmed it works with $ ruby extconf.rb --target-rbconfig=path/to/usr/local/lib/ruby/3.4.0+0/wasm32-wasi/rbconfig.rb
checking for rb_io_path()... yes
checking for rb_io_descriptor()... yes
checking for rb_io_get_write_io()... yes
checking for rb_io_closed_p()... yes
checking for rb_io_open_descriptor()... yes
$ make
# nop |
kateinoigakukun
added a commit
to ruby/ruby.wasm
that referenced
this pull request
Jun 18, 2024
kateinoigakukun
added a commit
to ruby/ruby.wasm
that referenced
this pull request
Jun 18, 2024
kateinoigakukun
added a commit
to ruby/ruby.wasm
that referenced
this pull request
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WASI does not support concept to provide termios, so it is not possible to build io/console extension on WASI at the moment.
However,
io/consoleis used by many gems, and removing the dependency from them conditionally is impossible. So, this commit adds a check to skip buildingio/consoleextension on WASI just to passgem installfor the platform.