Add RSpec-dev to Contributing; RSpec-Support to repos#65
Add RSpec-dev to Contributing; RSpec-Support to repos#65soulcutter merged 4 commits intorspec:sourcefrom
Conversation
source/contributing.html.slim
Outdated
There was a problem hiding this comment.
You shouldn't have to add 's to the tart of the lines, just add an actual space like used on _repos#16.
There was a problem hiding this comment.
Is it clear you can run middleman server to preview how this looks?
There was a problem hiding this comment.
Yeah, I did. I looked at repos partial for how you handled the spacing and saw the nbsp. I haven't used slim so just did what looked like the most consistent thing. About to push up a fix.
There was a problem hiding this comment.
Yeah it's only necessary at the end because it trims spaces and there's no haml style <> processor option I've found.
|
Otherwise, you think it's a good idea to just promote rspec-dev as the place for more info? I'm also wondering if the other repos DEV-README's might be out of date and should be removed. If not, I already called it out in the text. |
|
I think it would be better to promote this as a source of info and flesh it out more. |
|
@JonRowe I'm not sure I follow what you mean... |
|
If this was a detailed contribution guide with tips/caveats etc then we could just link to this page from the readmes. |
|
@JonRowe Still unclear if
and if you mean that rspec.github.io should have the how to develop info instead of rspec-dev? I'm not sure why I don't follow what you mean. 🐼 |
|
This PR and rspec.github.io, specifically the page in this PR should be a detailed contributing guide, which we can then link to from the project README.md's and just delete the DEV ones. |
|
A more-detailed contributing guide here would be nice, but I think this PR as-is is an improvement to what's there. I'd like to merge this and open an issue for a more-detailed guide. Let's wrap this one up! |
|
Needs rebasing before that can happen... Also my points about content still stand |
|
I can rebase and made some quick changes tonight |
|
I can't spend time on it right now, but I can triage this. Rebased |
|
This works for me for the time being. Opened another ticket for further improvements. Thanks for following up, @bf4 ! |
Add RSpec-dev to Contributing; RSpec-Support to repos
3 participants
No description provided.