Fix macOS build failure with older SDKs in QuartzWindow.mm#21282
Open
chrisburr wants to merge 1 commit intoroot-project:masterfrom
Open
Fix macOS build failure with older SDKs in QuartzWindow.mm#21282chrisburr wants to merge 1 commit intoroot-project:masterfrom
chrisburr wants to merge 1 commit intoroot-project:masterfrom
Conversation
Member
|
Thanks. Starting the tests. |
Test Results 22 files 22 suites 3d 5h 54m 12s ⏱️ Results for commit eb3136f. |
Member
|
@chrisburr thank you for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSView.clipsToBoundsis not declared inNSView.hin older macOS SDKs such as MacOSX11.0.sdk. This causes a build failure when compiling with these SDKs, as used by conda-forge:Failing conda-forge build: conda-forge/root-feedstock#335
This PR replaces
self.clipsToBounds = <value>with the equivalentself.layer.masksToBounds = <value>, guarded byself.wantsLayer = YESto ensure the view is layer-backed.layer.masksToBoundsis the Core Animation equivalent and is available across all SDK versions.Additionally, the overridden
didAddSubview:andwillRemoveSubview:methods now call theirsuperimplementations, which is standard practice when overriding these NSView methods.