Added new --no-config option to GetBinaryCommand, to skip generating config#38
Merged
butschster merged 1 commit intoroadrunner-php:masterfrom Apr 12, 2023
Merged
Conversation
…the config even in non-interactive mode
butschster
approved these changes
Sep 12, 2022
msmakouz
approved these changes
Sep 12, 2022
Contributor
Author
|
Hey! Considering there has been two reviews and two approvals, is there any reason to not merge this? |
Contributor
Author
|
@butschster @msmakouz could we get this landed? |
butschster
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
This adds a new
--no-configoption to the GetBinaryCommand so that config generation can be skipped even in no-interactive mode.Since it's a simple flag I have defined it inline, inside GetBinaryCommand, but I can switch it to a separated Option class as with
os,arch,version, etc.