Use DefaultSerde instead of JsonSerde for promise() default parameter#157
Merged
igalshilman merged 1 commit intorestatedev:mainfrom Dec 4, 2025
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
The default serde is supposed to be DefaultSerde, as defined in WorkflowContext. This bug forces users to explicitly declare serde=DefaultSerde(), even though it is already documented as the default in WorkflowContext.
c789a77 to
b1a64bb
Compare
igalshilman
approved these changes
Dec 4, 2025
Contributor
igalshilman
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the default serde parameter in
ServerInvocationContext.promise()to useDefaultSerde()instead ofJsonSerde(), aligning with the interface definition inWorkflowContext.Changes
JsonSerde()toDefaultSerde()inpromise()methodJsonSerdeimportMotivation
The default serde is supposed to be
DefaultSerde, as defined inWorkflowContext. This bug forces users to explicitly declareserde=DefaultSerde(), even though it is already documented as the default inWorkflowContext.Slack thread that originated this PR
Testing
Linting
Type Checking
Unit Tests