Conversation
This lockfile forces some really old transitive dependencies that prevent building in more recent python versions. In general -- im not a fan of lockfiles in packages (beyond lint requirements) as they prevent catching possible issues with later versions of libraries. In this case, im even more strongly opposed: the requirements.txt format makes lockfile maintenance very onerous.
salomon-smekecohen
force-pushed
the
py-ci
branch
from
8e0d655 to
c10694a
Compare
pacejackson
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Fix CI, test against modern python versions,
📜 Details
Im uncertain if this will work ootb or if this:
run: pip install -U pip setuptools==69.5.1 wheel==0.43.0 twine==5.0.0will need changing.🧪 Testing Steps / Validation
This PR itself is partly the test, as it runs the CI. However:
cirun OK on my local machine (except uploading)make lintworks✅ Checks