Simplify test bootstrap by using dev autoloader#169
Merged
WyriHaximus merged 1 commit intoreactphp:masterfrom Jun 26, 2018
Merged
Simplify test bootstrap by using dev autoloader#169WyriHaximus merged 1 commit intoreactphp:masterfrom
WyriHaximus merged 1 commit intoreactphp:masterfrom
Conversation
This is already being done in other repos of the organisation, let's make it more consistent then =)
Contributor
Author
|
These failures seem like flaky tests... |
jsor
approved these changes
Jun 26, 2018
Member
jsor
left a comment
jsor
left a comment
There was a problem hiding this comment.
Just realized that PHPUnit already loads vendor/autoload.php 🙂👍
clue
approved these changes
Jun 26, 2018
WyriHaximus
approved these changes
Jun 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is already being done in other repos of the organisation, let's make it more consistent then =)