fix: use RNC prefix for android modules#785
Merged
vonovak merged 1 commit intoreact-native-datetimepicker:masterfrom Jul 19, 2023
itsramiel:refactor/use-rnc-prefix-android
Merged
fix: use RNC prefix for android modules#785vonovak merged 1 commit intoreact-native-datetimepicker:masterfrom itsramiel:refactor/use-rnc-prefix-android
vonovak merged 1 commit intoreact-native-datetimepicker:masterfrom
itsramiel:refactor/use-rnc-prefix-android
Conversation
Member
|
thank you! 🙂 |
Member
|
🎉 This issue has been resolved in version 7.4.1 🎉 If this package helps you, consider sponsoring us! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 767 for context. In the past, the android date module was registered under
RNDatePickerAndroid. But when this package was updated to support the new arch, the module name was changed to be registered underRNDatePicker. The problem is that there is another popular package calledreact-native-date-picker, which was already registering its android module underRNDatePicker. Due to the change mentioned earlier, app that used to depend on both packages now are having a conflict as shown in the linked issue.This pr basically changes the android module registration names to have an
RNCprefix to align with other react native community packages and to resolve the conflict with the other packageTest Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)