Skip to content

gzip: improve bytes handling #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 3 commits into from
Oct 30, 2022
Merged

gzip: improve bytes handling #9037

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
308a000
gzip: improve bytes handling
sobolevn Oct 29, 2022
a47c9c9
Update gzip.pyi
sobolevn Oct 30, 2022
14d3163
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stdlib/gzip.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,9 @@ class _GzipReader(_compression.DecompressReader):
def __init__(self, fp: _ReadableFileobj) -> None: ...

if sys.version_info >= (3, 8):
def compress(data: bytes, compresslevel: int = ..., *, mtime: float | None = ...) -> bytes: ...
def compress(data: ReadableBuffer, compresslevel: int = ..., *, mtime: float | None = ...) -> bytes: ...
Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra Oct 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also does len(data) in one branch, so we should use _BufferWithLen.

Copy link
Copy Markdown
Member Author

@sobolevn sobolevn Oct 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!


else:
def compress(data: bytes, compresslevel: int = ...) -> bytes: ...
def compress(data: ReadableBuffer, compresslevel: int = ...) -> bytes: ...

def decompress(data: bytes) -> bytes: ...
def decompress(data: ReadableBuffer) -> bytes: ...