Clarify variance convention for Parameters#16302
Merged
hauntsaninja merged 3 commits intopython:masterfrom Oct 23, 2023
Merged
Conversation
AlexWaygood
reviewed
Oct 20, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: discord.py (https://github.com/Rapptz/discord.py)
+ discord/ext/commands/core.py:637: error: Unused "type: ignore" comment [unused-ignore]
- discord/ext/commands/core.py:639: error: Argument 1 has incompatible type "CogT"; expected Never [arg-type]
- discord/ext/commands/core.py:639: error: Argument 2 has incompatible type "Context[BotT]"; expected Never [arg-type]
- discord/ext/commands/core.py:639: error: Argument 3 has incompatible type "CommandError"; expected Never [arg-type]
|
hauntsaninja
approved these changes
Oct 23, 2023
Collaborator
|
I'll see if it gets reported again... Jukka said he'd make 1.7 release soon so may not be worth it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16296
In my big refactoring I flipped the variance convention for the
Parameterstype, but I did it inconsistently in one place. After working some more with ParamSpecs, it now seems to me the original convention is easier to remember. I also now explicitly put it in the type docstring.@hauntsaninja Not 100% sure, but this may be important enough for 1.6.2.