MyPy Exception Type Error Message Update

[ajrpeggio]

Fixes #5349 - Updating Error Messaging for Invalid Exception Type

[JukkaL]

Thanks for the PR! Can you update the failing tests to use the new error message?

[ajrpeggio]

Thanks for the PR! Can you update the failing tests to use the new error message?

Absolutely! I just updated the test cases :)

[hauntsaninja]

This looks great, thank you!

One possible nit: maybe "or be a tuple of exception classes"? I think the additional "be" makes it clearer in the presence of "derived"

[ajrpeggio]

This looks great, thank you!

One possible nit: maybe "or be a tuple of exception classes"? I think the additional "be" makes it clearer in the presence of "derived"

That's an easy adjustment. I'll do that now.

[hauntsaninja]

Thanks again! :-)

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

packaging (https://github.com/pypa/packaging) got 30.10 faster (3.7s -> 0.1s)

vision (https://github.com/pytorch/vision) got 1.20 slower (28.4s -> 34.0s)

[hauntsaninja]

(We're experimenting with reporting CI time differences, the performance numbers here are just noise)