Fix crash on single item union of alias#14876
Merged
ilevkivskyi merged 3 commits intopython:masterfrom Mar 18, 2023
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
OK, the tests are failing with exactly the traceback from the issue. I am going to apply the fix now. |
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Mar 11, 2023
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Looks good! Should it be testCompiledNoCrashOnSingleItemUnion instead of testNoCompiledCrashOnSingleItemUnion :-)
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
Author
|
I did some perf measurements and impact from this seems minimal, so I am going to merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14744
Note: I didn't add the fix yet (which is simple, although really subtle), because I want to check that test case I added consistently fails with compiled mypy.