Fix crash on star unpacking to underscore#14624
Merged
hauntsaninja merged 6 commits intopython:masterfrom Feb 8, 2023
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Feb 8, 2023
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Great! Can we clean up all the StarType code then?
Member
Author
Hm, it looks like yes, there are no more places where new (not copies) |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14250
This one is interesting. It looks like most likely this was caused by my PR #7127 that fixed other crash. After looking a bit more,
StarTypeis something old, and should never by used. At least I didn't findvisit_star_type()in any of the type visitors. Actually mypy already usesassert False, if we get to a non-special-cased star expression.Btw, I noticed that
pythonevaltest with empty expected output passes in case of a crash (at least on my machine), so I fix this too.