Enable Final instance attributes for attrs#14232
Merged
JukkaL merged 2 commits intopython:masterfrom Dec 6, 2022
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
JukkaL
reviewed
Dec 5, 2022
mypy/plugins/attrs.py
Outdated
| if attribute.name in ti.names: | ||
| sym_node = ti.names[attribute.name].node | ||
| if isinstance(sym_node, Var) and sym_node.is_final: | ||
| sym_node.final_set_in_init = True |
Collaborator
There was a problem hiding this comment.
This seems to potentially modify the symbol node of a base class. That is not safe to do, since we may have serialized an earlier version of the class, etc. So probably best to do this only for attributes defined in the current class?
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JukkaL
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick patch to enable the following scenario:
There are some edge cases I haven't covered here that would be complex to handle and not add much value IMO, so I think this will be useful like this.
For example:
This is technically not sound, but there might be an
__attrs_post_init__on the class or one of its ancestors and that function might set it.