stubtest: error if a function is async at runtime but not in the stub (and vice versa)#12212
Merged
hauntsaninja merged 2 commits intopython:masterfrom Feb 19, 2022
Merged
Conversation
… (and vice versa)
This comment has been minimized.
This comment has been minimized.
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks!
Error message nit: maybe is an "async def" in the stub, but not at runtime could be clearer? While "coroutine function" is true to the inspect call, I think it's less obvious.
Collaborator
|
The hooray for the mypy_primer is cute, but it would be quite unfortunate if stubtest ever did a thing to affect mypy_primer :D |
Member
Author
Well, obviously :P |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
approved these changes
Feb 19, 2022
Member
Author
|
Thanks! :D |
This was referenced Feb 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stubtest does not currently error if a function is async at runtime, but not in the stub (or vice versa). This PR fixes that!
This is an attempt at implementing a regression test for these typeshed PRs:
async defs inasyncio/tasks.pyitypeshed#6783async definstead ofdef ... -> Awaitableintypingtypeshed#7105async def, but aren't typeshed#7107cc. @hauntsaninja
Test Plan
I've added four test cases. Note that the test file needed a bit of rejigging, as
Coroutinewasn't defined in the stub fortypingthatteststubtestwas using.The changes in this PR generate three hits when checking typeshed. I'm not sure if they're true positives or not tbh: