bpo-28791: Update OS X installer to use SQLite 3.21.0.#4245
Merged
ned-deily merged 1 commit intopython:masterfrom Dec 5, 2017
Merged
bpo-28791: Update OS X installer to use SQLite 3.21.0.#4245ned-deily merged 1 commit intopython:masterfrom
ned-deily merged 1 commit intopython:masterfrom
Conversation
mlouielu
approved these changes
Nov 3, 2017
Contributor
mlouielu
left a comment
mlouielu
left a comment
There was a problem hiding this comment.
version, url and checksum looks good.
ned-deily
reviewed
Nov 3, 2017
Member
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
Thanks for the PR. I would prefer that this not be applied yet until I've had a chance to review and test the SQLite updates in the installer build context prior to the next alpha.
Member
Author
|
Thanks @ned-deily. Should I mark this as |
Member
|
It’s fine as is. I just won’t be able to get to it immediately. |
Member
Author
|
@ned-deily Will it be possible to include this in 3.7.0a3? Thanks. |
Member
|
I'm working on it now :) |
Member
|
LGTM, thanks! |
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Dec 5, 2017
ned-deily
added a commit
that referenced
this pull request
Dec 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue28791