bpo-45019: Cleanup module freezing and deepfreeze#29772
bpo-45019: Cleanup module freezing and deepfreeze#29772gvanrossum merged 2 commits intopython:mainfrom
Conversation
|
cc @gvanrossum |
928e1ff to
3bfd1cb
Compare
gvanrossum
left a comment
There was a problem hiding this comment.
Without looking carefully yet, I think I like your cleanup of freeze_modules.py, but not the rename of the deepfreeze directory. Can you undo the latter and just focus on improving the script?
EDIT: @gvanrossum done |
8fae1f6 to
db00ff0
Compare
gvanrossum
left a comment
There was a problem hiding this comment.
This is great. I have a few nits.
I also wonder if there aren't more improvements we can make, e.g. use relative paths throughout the code, rather than computing absolute paths and then making them relative for the generated code again.
Oh, and it would be nice to be able to freeze some submodules in a package but not all of them -- e.g. I'd like to freeze encodings/{__init__,utf_8,aliases}.py but not the remaining 100 submodules in that package.
|
Freeze encoding here #29788 |
gvanrossum
left a comment
There was a problem hiding this comment.
Looks good for this phase! I'll merge this now. Then you can work on e.g. changes groups of functions to classes and partially freezing encodings.
|
@gvanrossum: Please replace |
|
Thanks @gvanrossum This was my first contribution to cpython, earlier was just a typo fix, glad that you merged it :). |
|
Thanks Kumar for cleaning up our mess! :-) I am looking forward to seeing more from you. |
https://bugs.python.org/issue45019