Conversation
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
MaxwellDupre
left a comment
There was a problem hiding this comment.
I checked out this branch and modified the end of the your test script to:
a= r1.geturl() print (a) a =r1.url print (a)
And the output was None and None. For either of these to be useful shouldn't they output something other than none?
Also, could you add test(s) to the test module please?
iritkatriel
left a comment
There was a problem hiding this comment.
As mentioned above, a PR like this requires a unittest to assert that the bug being fixed does not reappear (though it's not clear that there is a bug here).
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
Apparently,
HTTPResponse.urlis accessed but not set by__init__norany other method. This PR initializes it through
__init__https://bugs.python.org/issue42062