bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier by zooba · Pull Request #18231 · python/cpython

zooba · 2020-01-28T09:57:35Z

https://bugs.python.org/issue39401

bedevere-bot · 2020-01-28T10:06:23Z

GH-18234 is a backport of this pull request to the 3.8 branch.

zooba · 2020-01-28T10:12:42Z

Two commits in this PR - the first is the backported change, while the second is the "real" change that we want for the future.

bedevere-bot · 2020-01-29T02:48:59Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows7 SP1 3.x has failed when building commit 6a65eba.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/81/builds/272) and take a look at the build logs.
Check if the failure is related to this commit (6a65eba) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/81/builds/272

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 9, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Compressing objects:  14% (1/7)        
remote: Compressing objects:  28% (2/7)        
remote: Compressing objects:  42% (3/7)        
remote: Compressing objects:  57% (4/7)        
remote: Compressing objects:  71% (5/7)        
remote: Compressing objects:  85% (6/7)        
remote: Compressing objects: 100% (7/7)        
remote: Compressing objects: 100% (7/7), done.        
remote: Total 11 (delta 2), reused 2 (delta 2), pack-reused 2        
From https://github.com/python/cpython
 * branch            master     -> FETCH_HEAD
Reset branch 'master'

Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\python*.zip

Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\python*.zip

bedevere-bot · 2020-01-29T02:54:58Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Windows7 3.x has failed when building commit 6a65eba.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/150/builds/227) and take a look at the build logs.
Check if the failure is related to this commit (6a65eba) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/150/builds/227

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 9, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Compressing objects:  14% (1/7)        
remote: Compressing objects:  28% (2/7)        
remote: Compressing objects:  42% (3/7)        
remote: Compressing objects:  57% (4/7)        
remote: Compressing objects:  71% (5/7)        
remote: Compressing objects:  85% (6/7)        
remote: Compressing objects: 100% (7/7)        
remote: Compressing objects: 100% (7/7), done.        
remote: Total 11 (delta 2), reused 2 (delta 2), pack-reused 2        
From https://github.com/python/cpython
 * branch            master     -> FETCH_HEAD
Reset branch 'master'

The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\python*.zip
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\PCbuild\\..\externals\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.

The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio
n, script file, or operable program. Check the spelling of the name, or if a pa
th was included, verify that the path is correct and try again.
At line:1 char:18
+ Invoke-WebRequest <<<<  https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db
3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals
\nuget.exe'
    + CategoryInfo          : ObjectNotFound: (Invoke-WebRequest:String) [], C 
   ommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 
'py' is not recognized as an internal or external command,
operable program or batch file.
'"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command,
operable program or batch file.
Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\python*.zip

@zooba

…8231) (GH-18232) https://bugs.python.org/issue39401 Automerge-Triggered-By: @zooba

@zooba

…8231) (GH-18234) https://bugs.python.org/issue39401 Automerge-Triggered-By: @zooba

…8231) (GH-18233)

…8231) As Windows 7 is not supported by Python 3.9, we just replace the dynamic load with a static import. Backports will have a different fix to ensure they continue to behave the same.

…thonGH-18231)" This reverts commit 6a65eba.

bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier

5ed9ebc

zooba added type-security A security issue OS-windows needs backport to 3.8 labels Jan 28, 2020

zooba requested a review from a team as a code owner January 28, 2020 09:57

the-knights-who-say-ni added the CLA signed label Jan 28, 2020

bedevere-bot added awaiting core review and removed needs backport to 3.8 labels Jan 28, 2020

Replace dynamic load with static import

4b0a3bc

zooba self-assigned this Jan 28, 2020

zooba merged commit 6a65eba into python:master Jan 29, 2020

zooba deleted the bpo-39401 branch January 29, 2020 02:46

bedevere-bot removed the awaiting core review label Jan 29, 2020

miss-islington pushed a commit that referenced this pull request Jan 30, 2020

[3.7] bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier (GH-1…

561c597

…8231) (GH-18232) https://bugs.python.org/issue39401 Automerge-Triggered-By: @zooba

miss-islington pushed a commit that referenced this pull request Jan 30, 2020

[3.8] bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier (GH-1…

ad4a20b

…8231) (GH-18234) https://bugs.python.org/issue39401 Automerge-Triggered-By: @zooba

ned-deily pushed a commit that referenced this pull request Jan 31, 2020

[3.6] bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier (GH-1…

51332c4

…8231) (GH-18233)

Hoikas mentioned this pull request Feb 25, 2021

[python3] Add feature deprecated-win7-support. microsoft/vcpkg#16420

Merged

kuba2k2 pushed a commit to kuba2k2/cpython that referenced this pull request Nov 13, 2021

Revert "bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier (py…

6bcabc2

…thonGH-18231)" This reverts commit 6a65eba.

kuba2k2 pushed a commit to kuba2k2/cpython that referenced this pull request Nov 13, 2021

Revert "bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier (py…

139b521

…thonGH-18231)" This reverts commit 6a65eba.

CAM-Gerlach mentioned this pull request May 9, 2022

gh-76773: Update docs mentioning no-longer-supported Windows versions & features #92529

Merged

5 tasks

BillyONeal mentioned this pull request Aug 4, 2023

[python3] Update to 3.11.4 microsoft/vcpkg#31727

Merged

kuba2k2 added a commit to kuba2k2/cpython that referenced this pull request Dec 5, 2024

Revert "bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier (py…

67ff714

…thonGH-18231)" This reverts commit 6a65eba.

kuba2k2 added a commit to kuba2k2/cpython that referenced this pull request Dec 5, 2024

Revert "bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier (py…

6c1e5ec

…thonGH-18231)" This reverts commit 6a65eba.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier#18231

bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier#18231
zooba merged 2 commits intopython:masterfrom
zooba:bpo-39401

zooba commented Jan 28, 2020 •

edited by bedevere-bot

Loading

Uh oh!

bedevere-bot commented Jan 28, 2020

Uh oh!

zooba commented Jan 28, 2020

Uh oh!

bedevere-bot commented Jan 29, 2020

Uh oh!

bedevere-bot commented Jan 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

zooba commented Jan 28, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Jan 28, 2020

Uh oh!

zooba commented Jan 28, 2020

Uh oh!

bedevere-bot commented Jan 29, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Jan 29, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zooba commented Jan 28, 2020 •

edited by bedevere-bot

Loading