-
-
Notifications
You must be signed in to change notification settings - Fork 34k
Disable pip version check when upgrading certifi #144632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @hugovk for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @hugovk for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit 80ba4e1) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
(cherry picked from commit 80ba4e1) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-144640 is a backport of this pull request to the 3.13 branch. |
|
GH-144641 is a backport of this pull request to the 3.14 branch. |
|
This PR adds
--disable-pip-version-checkto the pip invocation that upgradescertifiinInstall Certificates.command, to avoid warnings like this:Docs: https://pip.pypa.io/en/stable/cli/pip/#cmdoption-disable-pip-version-check
These sometimes show up on GitHub Actions as part of
actions/setup-python, which I as an end user has little control over. And the funny thing is, that action had just upgraded pip right before callingInstall Certificates.command. See python-pillow/Pillow#9424 (comment) for more details.I think avoiding the warning in this script is okay. In normal use, the user double clicks the "Install Certificates.command" icon during installation, the default terminal upgrades certifi then terminates.
People will still see the warning later on regular pip invocations when they're in a normal terminal session, which is when they can actually do something about it.
(Let me know if this PR needs an issue or news.)