Skip to content

gh-74902: Avoid hitting unicode.org for test data#144195

Merged
zware merged 1 commit intopython:mainfrom
zware:unicode_test_fixup
Jan 23, 2026
Merged

gh-74902: Avoid hitting unicode.org for test data#144195
zware merged 1 commit intopython:mainfrom
zware:unicode_test_fixup

Conversation

@zware
Copy link
Member

@zware zware commented Jan 23, 2026

Use our own pythontest.net instead.

Use our own pythontest.net instead.
@zware
Copy link
Member Author

zware commented Jan 23, 2026

unicode.org returned 403s to a couple of my buildbot workers; using pythontest.net instead ensures that we're not taxing their server and puts the source of our test data in our control.

Test data added to pythontest.net in python/pythontestdotnet@a66b3bb

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

f"into the test data directory")
except (OSError, HTTPException) as exc:
self.skipTest(f"Failed to download {TESTDATAURL}: {exc}")
TESTDATAFILE = "GraphemeBreakTest.txt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it is not in auxiliary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not; since we only have three files in there (up from two before adding this one), the extra directory seemed unnecessary. Easy enough to add back if you want it, though.

@zware zware merged commit 58ccf21 into python:main Jan 23, 2026
57 checks passed
@zware zware deleted the unicode_test_fixup branch January 23, 2026 21:07
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir topic-unicode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants