gh-141004: Don't trigger run-tests when Tools/check-c-api-docs/ignored_c_api.txt is changed#143583
Conversation
|
@hugovk maybe you could please take a look? |
ZeroIntensity
left a comment
There was a problem hiding this comment.
Thanks, I'm fine with this. Since it's right before the weekend, I'll give others a few more days to take a look before merging.
| Path(".github/CODEOWNERS"), | ||
| Path(".pre-commit-config.yaml"), | ||
| Path(".ruff.toml"), |
There was a problem hiding this comment.
It might be worth keeping CONFIGURATION_FILE_NAMES and just flattening it here, but I'm not going to block the PR on it.
|
Idle thought, we could write: if not (doc_file or file in RUN_TESTS_IGNORE):As: if not doc_file and file not in RUN_TESTS_IGNORE:I think that's a little clearer? An unrelated condition that could be made clearer in this file is: if not has_platform_specific_change or not platforms_changed:
a
else:
bIs the same as: if not (has_platform_specific_change and platforms_changed):
a
else:
bAnd flip to put the positive first: if has_platform_specific_change and platforms_changed:
b
else:
a |
|
Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…cs/ignored_c_api.txt` is changed (pythonGH-143583) (cherry picked from commit 1176fac) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
…cs/ignored_c_api.txt` is changed (pythonGH-143583) (cherry picked from commit 1176fac) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-143793 is a backport of this pull request to the 3.14 branch. |
|
GH-143794 is a backport of this pull request to the 3.13 branch. |
…cs/ignored_c_api.txt` is changed (pythonGH-143583)
Uh oh!
There was an error while loading. Please reload this page.