gh-141004: Document PyBytes_Repr and PyBytes_DecodeEscape#141407
Merged
ZeroIntensity merged 6 commits intopython:mainfrom Nov 11, 2025
Merged
gh-141004: Document PyBytes_Repr and PyBytes_DecodeEscape#141407ZeroIntensity merged 6 commits intopython:mainfrom
PyBytes_Repr and PyBytes_DecodeEscape#141407ZeroIntensity merged 6 commits intopython:mainfrom
Conversation
ZeroIntensity
added
needs backport to 3.13
bedevere-app
bot
added
awaiting core review
docs
Doc/c-api/bytes.rst
Outdated
Comment on lines
234
to
235
| Get the string representation of *bytes*. This function is used to | ||
| implement :meth:`!bytes.__repr__` in Python. |
Member
There was a problem hiding this comment.
Suggested change
| Get the string representation of *bytes*. This function is used to | |
| implement :meth:`!bytes.__repr__` in Python. | |
| Get the string representation of *bytes*. | |
| *bytes* must be a bytes object. | |
| This function is used to implement :meth:`!bytes.__repr__` in Python. |
Member
Author
There was a problem hiding this comment.
Same remark as the other PR, this reads as "segfault if this isn't a bytes object".
Member
There was a problem hiding this comment.
In this case, it will lead to undefined behaviour.
Member
Author
There was a problem hiding this comment.
Yuck! I think we should have a more explicit note then. That definitely surprised me.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @ZeroIntensity, I could not cleanly backport this to |
|
Sorry, @ZeroIntensity, I could not cleanly backport this to |
|
GH-141440 is a backport of this pull request to the 3.14 branch. |
ZeroIntensity
added a commit
to ZeroIntensity/cpython
that referenced
this pull request
Nov 12, 2025
…ythonGH-141407) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> (cherry picked from commit 37e2762)
ZeroIntensity
added a commit
to ZeroIntensity/cpython
that referenced
this pull request
Nov 12, 2025
…cape` (pythonGH-141407) (cherry picked from commit 37e2762) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-141441 is a backport of this pull request to the 3.13 branch. |
ZeroIntensity
added a commit
to ZeroIntensity/cpython
that referenced
this pull request
Nov 12, 2025
…ythonGH-141407) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> (cherry picked from commit 37e2762)
ZeroIntensity
added a commit
to ZeroIntensity/cpython
that referenced
this pull request
Nov 12, 2025
…cape` (pythonGH-141407) (cherry picked from commit 37e2762) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland
added a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…ythonGH-141407) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--141407.org.readthedocs.build/en/141407/c-api/bytes.html#c.PyBytes_Repr