GH-131296: fix clang-cl warnings in fileutils.c#131301
Closed
chris-eibl wants to merge 1 commit intopython:mainfrom
Closed
GH-131296: fix clang-cl warnings in fileutils.c#131301chris-eibl wants to merge 1 commit intopython:mainfrom
chris-eibl wants to merge 1 commit intopython:mainfrom
Conversation
chris-eibl
commented
Mar 15, 2025
| return 0; | ||
| } | ||
| if (ch > MAX_UNICODE) { | ||
| if (sizeof(ch) > 2 && ch > MAX_UNICODE) { |
Member
Author
There was a problem hiding this comment.
Fix warning : result of comparison of constant 1114111 with expression of type 'wchar_t' (aka 'unsigned short') is always false [-Wtautological-constant-out-of-range-compare]
chris-eibl
commented
Mar 17, 2025
|
|
||
| // mbstowcs() and mbrtowc() errors | ||
| static const size_t DECODE_ERROR = ((size_t)-1); | ||
| #ifdef HAVE_MBRTOWC |
Member
Author
There was a problem hiding this comment.
fix warning : unused variable 'INCOMPLETE_CHARACTER' [-Wunused-const-variable]
Member
Author
|
Closed because done similarily in #131487. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.