gh-128041: Add terminate_workers and kill_workers methods to ProcessPoolExecutor#130849
Merged
gpshead merged 6 commits intopython:mainfrom Mar 5, 2025
Merged
gh-128041: Add terminate_workers and kill_workers methods to ProcessPoolExecutor#130849gpshead merged 6 commits intopython:mainfrom
terminate_workers and kill_workers methods to ProcessPoolExecutor#130849gpshead merged 6 commits intopython:mainfrom
Conversation
…o ProcessPoolExecutor Add some fixes to tests to make them no longer transient
|
🤖 New build scheduled with the buildbot fleet by @gpshead for commit ec7599c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130849%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
colesbury
reviewed
Mar 4, 2025
colesbury
reviewed
Mar 4, 2025
Contributor
Author
|
I've run 75 times in a row now without a failure. @colesbury mind checking again. Thanks for the feedback! |
colesbury
reviewed
Mar 4, 2025
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 92a2d72 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130849%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Contributor
Author
|
I don't think those buildbot failures are related, but not 100% sure. |
gpshead
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a way to forcefully stop all the workers in the pool
Typically this would be used as a last effort to stop all workers if unable to shutdown / join in the expected way.
This is a newer version of #128043 that includes fixes for transient issues seen in CI.
terminate_workerstoProcessPoolExecutor#128041📚 Documentation preview 📚: https://cpython-previews--130849.org.readthedocs.build/