gh-111049: Fix crash during garbage collection of the BytesIO buffer object by serhiy-storchaka · Pull Request #111221 · python/cpython

serhiy-storchaka · 2023-10-23T16:04:14Z

Issue: Segfault during garbage collection with GzipFile + failed urllib3 request on 3.12.0 #111049

…uffer object

Lib/test/test_memoryio.py

Modules/_io/bytesio.c

Lib/test/test_memoryio.py

bedevere-app · 2023-10-25T13:47:28Z

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

…ffer-gc' into crash-bytesio-getbuffer-gc

serhiy-storchaka · 2023-10-30T07:21:13Z

@erlend-aasland I do not understand, what exactly changes did you request. Could you please explain it in more details?

serhiy-storchaka · 2023-10-30T15:31:05Z

Thank you for your suggestion @erlend-aasland. I have made the requested changes; please review again.

basepi · 2023-10-30T17:44:06Z

I have made the requested changes; please review again.

I think this needs to be in a comment by itself, looks like the bot didn't remove the label.

AlexWaygood · 2023-10-30T17:56:18Z

I have made the requested changes; please review again.

I think this needs to be in a comment by itself, looks like the bot didn't remove the label.

no, the bot is malfunctioning at the moment:

Bedevere doesn't say "thank you" for making the requested changes anymore bedevere#599

Lib/test/test_memoryio.py

basepi · 2023-11-13T21:36:12Z

Any movement here? It would be lovely to get this fix into 3.12.1.

erlend-aasland

Please remove the XXX from the comments as per PEP-8:

Ensure that your comments are clear and easily understandable to other speakers of the language you are writing in.

Python coders from non-English speaking countries: please write your comments in English, unless you are 120% sure that the code will never be read by people who don’t speak your language.

XXX is neither clear, easily understandable, nor english; please remove it.

Lib/test/test_memoryio.py

basepi · 2023-12-11T19:06:25Z

@serhiy-storchaka Can you please remove the instances of XXX so we can get this merged? Frustrated that we missed 3.12.1 with this fix.

serhiy-storchaka · 2023-12-14T09:51:28Z

I decided to remove them at all. I tried to silence errors, but they serve as indication of programming error, similar to ResourceWarning. When memoryview is explicitly released or used as a context manager, this never happens.

bedevere-app · 2023-12-14T10:04:35Z

GH-113096 is a backport of this pull request to the 3.12 branch.

…uffer object (pythonGH-111221) (cherry picked from commit bb36f72) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

…buffer object (GH-111221) (GH-113096) (cherry picked from commit bb36f72) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

…uffer object (pythonGH-111221)

pythongh-111049: Fix crash during garbage collection of the BytesIO b…

d2d8ed2

…uffer object

serhiy-storchaka added the needs backport to 3.12 only security fixes label Oct 23, 2023

bedevere-app bot mentioned this pull request Oct 23, 2023

Segfault during garbage collection with GzipFile + failed urllib3 request on 3.12.0 #111049

Closed

bedevere-app bot added the awaiting core review label Oct 23, 2023

serhiy-storchaka commented Oct 23, 2023

View reviewed changes

Lib/test/test_memoryio.py Outdated Show resolved Hide resolved

Lib/test/test_memoryio.py Outdated Show resolved Hide resolved

Modules/_io/bytesio.c Show resolved Hide resolved

Remove debugging remnants.

131142b

erlend-aasland requested review from erlend-aasland and kumaraditya303 October 23, 2023 18:41

Merge branch 'main' into crash-bytesio-getbuffer-gc

160896f

erlend-aasland requested changes Oct 25, 2023

View reviewed changes

Lib/test/test_memoryio.py Outdated Show resolved Hide resolved

bedevere-app bot removed the awaiting core review label Oct 25, 2023

bedevere-app bot added the awaiting changes label Oct 25, 2023

serhiy-storchaka added 2 commits October 25, 2023 18:03

Merge branch 'main' into crash-bytesio-getbuffer-gc

10ed7d0

Merge remote-tracking branch 'refs/remotes/origin/crash-bytesio-getbu…

57fa654

…ffer-gc' into crash-bytesio-getbuffer-gc

furkanonder added the type-crash A hard crash of the interpreter, possibly with a core dump label Oct 26, 2023

serhiy-storchaka added 2 commits October 30, 2023 17:29

Address review comments.

cb70991

Merge branch 'main' into crash-bytesio-getbuffer-gc

046362f

erlend-aasland reviewed Oct 31, 2023

View reviewed changes

Lib/test/test_memoryio.py Outdated Show resolved Hide resolved

Lib/test/test_memoryio.py Outdated Show resolved Hide resolved

erlend-aasland requested changes Nov 15, 2023

View reviewed changes

Lib/test/test_memoryio.py Outdated Show resolved Hide resolved

Lib/test/test_memoryio.py Outdated Show resolved Hide resolved

basepi mentioned this pull request Dec 11, 2023

build(deps): Bump python from 3.11.5-slim to 3.12.1-slim elastic/opbeans-python#306

Closed

erlend-aasland and others added 3 commits December 11, 2023 23:20

Merge branch 'main' into crash-bytesio-getbuffer-gc

47f20ea

Merge branch 'main' into crash-bytesio-getbuffer-gc

be1ea22

Remove XXX comments.

621345b

serhiy-storchaka force-pushed the crash-bytesio-getbuffer-gc branch from 0c693c0 to 621345b Compare December 14, 2023 09:44

erlend-aasland approved these changes Dec 14, 2023

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting changes labels Dec 14, 2023

serhiy-storchaka enabled auto-merge (squash) December 14, 2023 09:51

serhiy-storchaka merged commit bb36f72 into python:main Dec 14, 2023

This comment was marked as outdated.

Sign in to view

bedevere-app bot removed the awaiting merge label Dec 14, 2023

bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 14, 2023

serhiy-storchaka added a commit that referenced this pull request Dec 14, 2023

[3.12] gh-111049: Fix crash during garbage collection of the BytesIO …

9f5209f

…buffer object (GH-111221) (GH-113096) (cherry picked from commit bb36f72) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

corona10 pushed a commit to corona10/cpython that referenced this pull request Dec 15, 2023

pythongh-111049: Fix crash during garbage collection of the BytesIO b…

43fea31

…uffer object (pythonGH-111221)

basepi mentioned this pull request Jan 18, 2024

Segfault for short-lived Client objects in python 3.12 elastic/apm-agent-python#1916

Closed

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024

pythongh-111049: Fix crash during garbage collection of the BytesIO b…

db183c4

…uffer object (pythonGH-111221)

serhiy-storchaka deleted the crash-bytesio-getbuffer-gc branch March 12, 2024 10:11

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024

pythongh-111049: Fix crash during garbage collection of the BytesIO b…

2a1f6ae

…uffer object (pythonGH-111221)

Uh oh!

Conversation

serhiy-storchaka commented Oct 23, 2023 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-app bot commented Oct 25, 2023

Uh oh!

serhiy-storchaka commented Oct 30, 2023

Uh oh!

serhiy-storchaka commented Oct 30, 2023

Uh oh!

basepi commented Oct 30, 2023

Uh oh!

AlexWaygood commented Oct 30, 2023

Uh oh!

Uh oh!

Uh oh!

basepi commented Nov 13, 2023

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

basepi commented Dec 11, 2023

Uh oh!

serhiy-storchaka commented Dec 14, 2023

Uh oh!

This comment was marked as outdated.

bedevere-app bot commented Dec 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

serhiy-storchaka commented Oct 23, 2023 •

edited by bedevere-app bot

Loading