asyncio.streams.open_connection remove loop from docstring#108528
Merged
gvanrossum merged 2 commits intopython:mainfrom Sep 27, 2023
Merged
asyncio.streams.open_connection remove loop from docstring#108528gvanrossum merged 2 commits intopython:mainfrom
gvanrossum merged 2 commits intopython:mainfrom
Conversation
asyncio.streams.open_connection no longer accepts loop as a keyword argument and providing it causes: TypeError: BaseEventLoop.create_connection() got an unexpectedkeyword argument 'loop' therefore remove it from the docstring.
tgbugs
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Contributor
Author
|
This is a trivial change so if someone who has signed the CLA wants to submit it I don't mind. |
gvanrossum
approved these changes
Sep 13, 2023
gvanrossum
added
needs backport to 3.11
Member
|
@tgbugs: Could you please sign the CLA? It would really be much easier that way -- I can't merge without it. |
Contributor
Author
|
@gvanrossum CLA signed. |
Contributor
|
Thanks @tgbugs for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 27, 2023
…nGH-108528) (cherry picked from commit e721f7a) Co-authored-by: Tom Gillespie <tgbugs@gmail.com>
|
GH-109941 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 27, 2023
…nGH-108528) (cherry picked from commit e721f7a) Co-authored-by: Tom Gillespie <tgbugs@gmail.com>
|
GH-109942 is a backport of this pull request to the 3.11 branch. |
Member
|
@tgbugs I just realized (seconds after merging :-) that a similar change needs to be applied to open_connection(). Are you interested in taking that on, now that you've got the CLA signed and all? |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Sep 27, 2023
…GH-108528) (#109942) Remove loop from docstring for asyncio.streams.open_connection (GH-108528) (cherry picked from commit e721f7a) Co-authored-by: Tom Gillespie <tgbugs@gmail.com>
Contributor
Author
|
Happy to, but won't be able to get to it until late next week of that
matters.
…On Wed, Sep 27, 2023, 12:42 Guido van Rossum ***@***.***> wrote:
@tgbugs <https://github.com/tgbugs> I just realized (seconds after
merging :-) that a similar change needs to be applied to open_connection().
Are you interested in taking that on, now that you've got the CLA signed
and all?
—
Reply to this email directly, view it on GitHub
<#108528 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAZYABLAISZZEKVQDC75XLX4OOCRANCNFSM6AAAAAA4ABRYYM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
@tgbugs No problem, take your time. |
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
Yhg1s
pushed a commit
that referenced
this pull request
Oct 2, 2023
…GH-108528) (#109941) Remove loop from docstring for asyncio.streams.open_connection (GH-108528) (cherry picked from commit e721f7a) Co-authored-by: Tom Gillespie <tgbugs@gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio.streams.open_connection no longer accepts loop as a keyword argument and providing it causes:
TypeError: BaseEventLoop.create_connection() got an unexpectedkeyword argument 'loop' therefore remove it from the docstring.