Add AAAS journals to subplot command#30
Add AAAS journals to subplot command#30lukelbd merged 2 commits intoproplot-dev:masterfrom bradyrx:add_aaas_journals
Conversation
|
Feel free to review directly if you want anything changed. Or you can pull it down and edit, push, then merge. You need to add a travis CI webhook, and .travis file, etc. for the tests to run on a PR like this. |
|
FYI, this is a solid template for travis: https://github.com/bradyrx/climpred/blob/master/.travis.yml. I may be biased though. Then you just need to activate your repo here (https://travis-ci.org/) and add the webhook. Then it will always run on every PR, ensuring that the package can be built and that all testing passes. |
|
Looks good to go. Thanks for the tips. Didn't know about the PEP8 recommendation re: constants. I have a bunch of constants throughout the module, decided to also make them all caps (c2ae600) and gotta admit it's nice to know at-a-glance where each function is using a global variable. |
These are the kind of things that come up through open source code review via PRs. I learned that one from a collaborator on climpred. FYI, @lukelbd, the So eventually you might want to host that on your docs. |
@lukelbd, this PR adds the AAAS journal specs to the
proplot.subplots()command. It also has a few minor fixes:JOURNAL_SPECSfollowing PEP (https://www.python.org/dev/peps/pep-0008/#constants).subplots()that was causing certain journal specs to break.pytestfor all journal specs as a template for future testing.This is a great simple example of pytest's power. I created the test then ran pytest and found consistent errors in certain subsets of the dictionary (
TypeErrorvs.ValueError). Once you get pytest implemented into Travis CI, this will run automatically on PRs and then you have no risk of importing broken code. At least broken journal spec code for now.