Skip to content
This repository was archived by the owner on Jul 6, 2021. It is now read-only.

Feature/external tools#56

Merged
btry merged 6 commits intodevelopfrom
feature/external-tools
Feb 20, 2017
Merged

Feature/external tools#56
btry merged 6 commits intodevelopfrom
feature/external-tools

Conversation

@trasher
Copy link
Contributor

@trasher trasher commented Feb 10, 2017

No description provided.

Copy link
Contributor

@btry btry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is useless to add composer.lock to tracked files.

Also, there are 2 indentation problems.

break;

case '1.4':
case '1.4.1':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pbpcbf was probably a bit lost here.


$DB->query($sql) or die($DB->error());
}
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation here too

@trasher
Copy link
Contributor Author

trasher commented Feb 20, 2017

I think it is useless to add composer.lock to tracked files.

Not really; this ensures the versions used are "fixed" on composer install

Copy link
Contributor

@btry btry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@btry btry merged commit d1358d5 into develop Feb 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants