Merged
Conversation
- import and export those required in plotly.js - pre-bundle stackgl/gl-vis modules using node16 - test npm ci using npm v6 and cibuild with node12
alexcjohnson
approved these changes
Oct 28, 2021
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
Ha ok - interesting solution. I still feel like long-term we'd be better served by inlining these modules as folders here so their ultimate source is in this repo, and development can continue without having to coordinate between repos at all.
But yes this will solve the issues you reference relating to old node versions or inaccessible GitHub, so let's go with it. 💃
This was referenced Nov 3, 2021
archmoj
commented
Nov 5, 2021
| "surface-nets": "plotly/surface-nets#v1.1.1", | ||
| "svg-path-sdf": "^1.1.3", | ||
| "tinycolor2": "^1.4.2", | ||
| "to-px": "1.0.1", |
Contributor
Author
There was a problem hiding this comment.
to-px version should have been kept at 1.0.1 otherwise causing #6010.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the #897 work, this PR help
close #5925 &
close #5929 &
close #5966 &
close #5980 for the npm 6 and node <= 14 users.
stackglandgl-visparts intostackgl_modulesfolder and pre-bundle it using node16node-12andnpm-6.@plotly/plotly_js