Make sure function scope is set in closure in constant expression #4827
+93
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This pull request has been marked as ready for review. |
ruudk
force-pushed
the
make-sure-function-scope-is-set-for-callable-in-attribute
branch
2 times, most recently
from
14fa284 to
16a3cc7
Compare
Contributor
Author
|
@ondrejmirtes I rebased with main, then tried to see if I could get a test that uses StaticMethodParameterClosureTypeExtension. But I feel like this is not the right extension point. |
ondrejmirtes
force-pushed
the
make-sure-function-scope-is-set-for-callable-in-attribute
branch
from
16a3cc7 to
eaf4ec7
Compare
ondrejmirtes
requested changes
Feb 10, 2026
| // Then we would want to find out the 1st parameter of __invoke | ||
| // It would be SomeCommand. | ||
| // Then we would want to return that the callable signature is `static function (SomeCommand): string` | ||
| // But I'm not sure if this is the correct extension point at all... |
Member
There was a problem hiding this comment.
Why do you feel that? Did you try to implement the logic here along with the change to NodeScopeResolver to see if my suggestion worked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See phpstan/phpstan#14014 (reply in thread)
Let's see what the tests say.