PowerPC64 support in safe_address function#919
Closed
gustavotemple wants to merge 1 commit intophp:masterfrom
gustavotemple:memory-address-overflow-ppc64
Closed
PowerPC64 support in safe_address function#919gustavotemple wants to merge 1 commit intophp:masterfrom gustavotemple:memory-address-overflow-ppc64
gustavotemple wants to merge 1 commit intophp:masterfrom
gustavotemple:memory-address-overflow-ppc64
Conversation
Author
|
@remicollet, @smalyshev, @datibbaw, @laruence: the PR #734 has been rebased in this one. |
Member
|
Tried against master on This make ext/spl/tests/bug67247.phpt segfault: Without the patch With: |
Member
|
FYI, we now have 0 failed tests on ppc64, so testing will be easier (build with --disable-all, so no extension tested) |
Author
|
@remicollet, thank you very much :) |
Member
|
Any update on this one ? (still segfault) |
Author
|
Sorry @remicollet, not yet, I and my teammates (@caioso, @lbianc) we're still checking. |
Member
|
@gustavotemple no urgency ;) |
Add a ppc64-specific implementation of the safe_address function with overflow checking.
Author
|
@remicollet, done, fixed. |
Member
|
Tested on No regression detected. Fine :) |
|
Comment on behalf of remi at php.net: merged, thanks for improving PHP on PowerPC :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a ppc64-specific implementation of the safe_address
function with overflow checking.