Added escape parameter to SplFileObject::fputcsv

[salathe]

See https://bugs.php.net/bug.php?id=68479

[smalyshev]

@salathe Test SplFileObject_fputcsv_error.phpt fails, please fix.

[salathe]

@smalyshev that'll teach me for just running the one new test! Updated SplFileObject_fputcsv_error.phpt as appropriate. None of the SPL tests fail. 😄

[jpauli]

Hi,
I'm trying to merge that.
I fail on master about this test. There seems to be an & missing, like if the reflection returned references and not any more in master.

003+ object(ReflectionParameter)#2 (1) {
003- &object(ReflectionParameter)#2 (1) {
008+ object(ReflectionParameter)#3 (1) {
008- &object(ReflectionParameter)#3 (1) {
013+ object(ReflectionParameter)#4 (1) {
013- &object(ReflectionParameter)#4 (1) {
018+ object(ReflectionParameter)#5 (1) {
018- &object(ReflectionParameter)#5 (1) {

Should we fix the tests against master as well ?

[salathe]

@jpauli Feel free to change the test in master for the different output.

[jpauli]

Asking Dmitry about it ...

[jpauli]

Ok, so the tests should be patched against master.
Will do it and merge that soon

[php-pulls]

Comment on behalf of jpauli at php.net:

Merged