Closed
Conversation
Member
Author
|
cc @Girgias is there any other need to revert a commit ? keeping as place holder for now. |
Member
|
See #16870 (comment). I still don't think we should revert. |
Member
Author
|
I keep as draft atm anyway. |
cmb69
approved these changes
Nov 26, 2024
Member
Author
|
fair enough, once @Girgias validate the list of commits to revert, I ll proceed. Best we can, eventually, is to document the behavior ? |
Girgias
approved these changes
Nov 27, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Other than the NEWS remark, LGTM.
Comment on lines
119
to
126
| - GMP: | ||
| . Fixed floating point exception bug with gmp_pow when using | ||
| large exposant values. (David Carlier). | ||
| . Fixed bug GH-16411 (gmp_export() can cause overflow). (cmb) | ||
| . Fixed bug GH-16501 (gmp_random_bits() can cause overflow). | ||
| (David Carlier) | ||
| . Fixed gmp_pow() overflow bug with large base/exponents. | ||
| (David Carlier) |
Member
There was a problem hiding this comment.
I don't think we should edit the NEWS file for prior entries, better to leave them and add new NEWS entries.
Member
Author
|
Merged with 45140e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.