Fix GH-15701: fopencookie seek callback signature offset argument mis…

[devnexen]

…match.

[devnexen]

ping :)

[cmb69]

I'm not generally against this change, but I'm slightly concerned that we may cure the wrong symptoms here. That is all quite contrived. We use zend_off_t, PHP_FPOS_T, off64_t, and off_t pretty arbitrarily. I think it is more important to clean that up (maybe master only), than adding work-arounds for ancient OS versions.

[bukka]

But glibc defines

typedef int cookie_seek_function_t (void *__cookie, __off64_t *__pos, int __w);

(documented as int seeker (void *cookie, off64_t *position, int whence))

So now you just use fpos_t to be equal to off64_t which it is but this makes it kind of messy. If there are difference I would prefere to create a special type for cookie_seek_function_t rather than reusing fpos_t.

[bukka]

Shouldn't we just always use off64_t or some wrapper around it? Are there any platforms where directly using off64_t with IO cookies wouldn't work?

[cmb69]

We should at least unify zend_off_t and PHP_FPOS_T.