Merged
Conversation
dbu
approved these changes
Jul 30, 2019
Contributor
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
i think we should bump all the way to PHP 7.1 while we are at it. and increase the minor version in the composer branch-alias so we will be 2.2. i guess in this case its very unlikely to matter, but just out of principle so that we can release security fixes that people stuck on legacy php versions.
xabbuh
approved these changes
Jul 30, 2019
xabbuh
requested changes
Jul 30, 2019
Member
xabbuh
left a comment
xabbuh
left a comment
There was a problem hiding this comment.
In fact, we need to update the PHP version for the job that runs with lowest dependencies too.
nenad
force-pushed
the
patch/stop-support-5-5
branch
from
4c8e008 to
dbd3f10
Compare
Contributor
Author
I removed PHP 5.5 from the Travis build completely. Does this comment refer to adding the lowest dependencies job to PHP 7.1 or some other version? |
dbu
reviewed
Jul 30, 2019
xabbuh
approved these changes
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Stop support for PHP 5.5
Why?
Prevents us from migrating to newer version of react components.