[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12275] Skip unsupported experiment type during flag decision #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during flag decision - Add optional 'type' parameter to Experiment class in entities.py - Define SUPPORTED_EXPERIMENT_TYPES constant (a/b, mab, cmab, feature_rollouts) - Update get_decision_for_flag to skip experiments with unsupported types - Skip evaluation only if type is defined but not in supported list - Evaluate normally if type is None or is supported - Add unit tests for experiment type filtering scenarios Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements experiment type filtering in the decision service to skip unsupported experiment types during flag decision evaluation.
Changes
typeparameter to theExperimentclass inentities.pySUPPORTED_EXPERIMENT_TYPESconstant with values:a/b,mab,cmab,feature_rolloutsget_decision_for_flagin decision service to:Implementation Details
The decision service now checks the experiment
typefield during flag decision:typeis None: Experiment is evaluated (backward compatible)typeis in supported list: Experiment is evaluatedtypeis defined but NOT in supported list: Experiment is skipped with debug logThis ensures the SDK can gracefully handle new experiment types introduced in the datafile without breaking existing functionality.
Test Plan
Related
🤖 Generated with Claude Code