[OP CONFORMANCE][TEMPLATE] Fix Interpolate test fails in op conformance Fixes #23553 #34587
Open
ktk-07 wants to merge 1 commit intoopenvinotoolkit:masterfrom
Open
[OP CONFORMANCE][TEMPLATE] Fix Interpolate test fails in op conformance Fixes #23553 #34587ktk-07 wants to merge 1 commit intoopenvinotoolkit:masterfrom
ktk-07 wants to merge 1 commit intoopenvinotoolkit:masterfrom
Conversation
…r 4D input. The conformance IR uses axes=[1,2] for a 4D tensor with mode='linear_onnx'. According to the Interpolate-11 and Interpolate-4 specification for mode=linear_onnx, only axes={2,3} are supported for 4D inputs, so this configuration is skipped in op conformance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR skips an unsupported Interpolate-11
linear_onnxconfiguration in op conformance tests.The failing IR uses:
mode = "linear_onnx"axes = [1,2][1, 65, 65, 21](4D)According to the OpenVINO Interpolate specification, when
mode="linear_onnx"the supported axes are:{0,1}{0,1,2}{2,3}{2,3,4}For a 4D tensor, only
{2,3}are supported.The conformance IR uses
axes=[1,2], which is outside the documented supported configuration.interploate-11 documentation
interpolate-4 documentation
The reference implementation therefore throws:
Root Cause
The failure occurs in the reference implementation:
linear_onnx_funcvalidates the axes and throws an exception when encountering[1,2]for 4D input. OPENVINO_THROW("Axes are not correct!");This causes the Inference test to fail during reference calculation, while
QueryModelandImportExportpass.Change
Solution was to mark the test as SKIPPED instead of FAILED so it is not reported as a plugin failure.
A check was added in:
If the test detects:
Interpolatev4/v11mode = linear_onnxaxes = [1,2]the test calls:
GTEST_SKIP() with a short explanation. "Interpolate linear_onnx with axes [1,2] for 4D is not supported by reference; skipping."
Alternatives Considered
1. Extend the reference implementation
axes=[1,2]inreference/interpolate.hpp. However this would change reference behavior and a previous attempt (PR Fix #23553: [OP CONFORMANCE][TEMPLATE] Interpolate test fails in op c… #23636) which caused additional failures.2. Filter this IR during conformance IR generation
The problematic IR could be removed from the conformance dataset so that only valid configurations are tested.
This may be a better long-term solution but requires changes to the IR generation pipeline.
IMPORTANT NOTES
This PR provides a minimal solution to prevent an out-of-spec IR configuration from being reported as a plugin failure.
Maintainer feedback would be helpful to determine whether:
Tickets
Fixes #23553
AI Assistance
AI was used to help navigate the OpenVINO codebase and understand the conformance testing flow.
All code changes and final validation were implemented manually and verified by me.